fix(ci): run GoReleaser directly after release-please creates a release#9
Merged
Merged
Conversation
The release.yml workflow was not triggering for new releases because GitHub prevents workflows from triggering other workflows when using GITHUB_TOKEN (to avoid infinite loops). This caused the Homebrew formula to stay at v0.1.0 while releases v0.1.1-v0.1.4 were created. This fix adds GoReleaser steps directly in release-please.yml, running only when a release is created (using release_created output).
leonardomso
force-pushed
the
fix/homebrew-release-workflow
branch
from
ca82c2f to
dd122d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release-please.ymlworkflowrelease.yml(1.25.5 → 1.23)Problem
The
release.ymlworkflow was not triggering for new releases because GitHub prevents workflows from triggering other workflows when usingGITHUB_TOKEN(to avoid infinite loops). This caused the Homebrew formula to remain at v0.1.0 while releases v0.1.1 through v0.1.4 were created but never built/published to Homebrew.Solution
Instead of relying on the tag push event to trigger a separate workflow, GoReleaser now runs directly within the
release-please.ymlworkflow immediately after a release is created. The steps only execute whensteps.release.outputs.release_createdis true.Note
After merging this PR, you may want to manually trigger GoReleaser for v0.1.4 to update the Homebrew tap, or wait for the next release.