add a test to validate important scenarios.#462
Open
qibinhang wants to merge 1 commit intolets-blade:v2.1.3from
Open
add a test to validate important scenarios.#462qibinhang wants to merge 1 commit intolets-blade:v2.1.3from
qibinhang wants to merge 1 commit intolets-blade:v2.1.3from
Conversation
|
这是来自QQ邮箱的自动回复邮件。
您好,我是沈思佳,您的邮件已经收到啦,查看后马上给您回复~
|
Author
|
您好,请问这个测试用例是否有用,特别是检测潜在的回归问题? |
|
这是来自QQ邮箱的自动回复邮件。
您好,我是沈思佳,您的邮件已经收到啦,查看后马上给您回复~
|
|
已收到,我会尽快回复你!
——刘劲字
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that the
checkpwmethod incom.hellokaton.blade.kit.BCryptis not fully tested. Specifically, the current test suite does not cover the branchif (hashed_bytes.length != try_bytes.length), which handles scenarios where the stored password hashes may be corrupted. These scenarios are important to consider, as real-world issues—often introduced during database migrations or system updates—can lead to such inconsistencies.To address this gap, I’ve added a test that explicitly validates this scenario. I hope it proves helpful in detecting potential regressions.
If additional test coverage would be valuable, I’d be happy to contribute further by looking into other classes you consider important for a follow-up PR.