[WIP] Add BOOT_REASON_HW_WATCHDOG and KUBE_TRANSITION#148
Draft
eriknordmark wants to merge 2 commits into
Draft
Conversation
Add BOOT_REASON_HW_WATCHDOG (16) so a device reset by its hardware watchdog can be reported distinctly instead of being guessed as a kernel panic or unknown reboot. The flag is only set on platforms whose watchdog driver reports WDIOF_CARDRESET; many (e.g. Intel iTCO) report a zero boot status, so this value will not appear there. Also add BOOT_REASON_KUBE_TRANSITION (15), which already exists in pkg/pillar/types.BootReason but was missing from this enum, restoring the documented one-to-one correspondence with the pillar values. Signed-off-by: eriknordmark <erik@zededa.com> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
No functional changes; generated code and assets only. Signed-off-by: eriknordmark <erik@zededa.com> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
6 tasks
eriknordmark
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is moderately useful on arm64 due to the lack of support in the common Intel iTCO driver.
@rene do you know which hardware watchdog drivers are common on ARM so we can check whether the set bootreason to something other than zero?
Add two values to the
BootReasonenum ininfo.proto:BOOT_REASON_HW_WATCHDOG(16) lets a device that was reset by itshardware watchdog report that distinctly, instead of being reported as a
kernel panic (
BOOT_REASON_KERNEL) or an unknown reboot. The flag is onlyset on platforms whose watchdog driver reports
WDIOF_CARDRESET; many(e.g. Intel iTCO) always report a zero boot status, so the value will not
appear on those.
BOOT_REASON_KUBE_TRANSITION(15) already exists inpkg/pillar/types.BootReasonbut was missing from this enum. Adding itrestores the documented one-to-one correspondence with the pillar values.
Both are additive field numbers, so the change is wire-compatible — existing
controllers and existing EVE instances continue to interoperate.
The pillar code that records and consumes the new reason is in a companion
lf-edge/eve PR.
Commits follow the repo's two-commit convention: the
.protochange isseparate from the regenerated Go/Python bindings.