Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,6 @@ module.exports = {
},
rules: {
'no-prototype-builtins': 0,
eqeqeq: ['error', 'always'],
},
};
24 changes: 24 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
name: CI

on:
push:
branches: [master]
pull_request:
branches: [master]

jobs:
test:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [16, 18, 20]
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
- run: npm install
- run: npm run lint
- run: npm run unit
env:
NODE_OPTIONS: ${{ matrix.node-version >= 18 && '--openssl-legacy-provider' || '' }}
13 changes: 3 additions & 10 deletions index.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
const utils = require('./utils');

const scopedModuleRegex = new RegExp(
'@[a-zA-Z0-9][\\w-.]+/[a-zA-Z0-9][\\w-.]+([a-zA-Z0-9./]+)?',
'g'
);
const scopedModuleRegex =
/@[a-zA-Z0-9][\w-.]+\/[a-zA-Z0-9][\w-.]+([a-zA-Z0-9./]+)?/;

function getModuleName(request, includeAbsolutePaths) {
let req = request;
Expand All @@ -14,8 +12,6 @@ function getModuleName(request, includeAbsolutePaths) {
}
// check if scoped module
if (scopedModuleRegex.test(req)) {
// reset regexp
scopedModuleRegex.lastIndex = 0;
return req.split(delimiter, 2).join(delimiter);
}
return req.split(delimiter)[0];
Expand All @@ -25,10 +21,7 @@ module.exports = function nodeExternals(options) {
options = options || {};
const mistakes = utils.validateOptions(options) || [];
if (mistakes.length) {
mistakes.forEach((mistake) => {
utils.error(mistakes.map((mistake) => mistake.message));
utils.log(mistake.message);
});
utils.error(mistakes.map((mistake) => mistake.message));
}
const webpackInternalAllowlist = [/^webpack\/container\/reference\//];
const allowlist = []
Expand Down
Loading