Restore the operator listings and drop the unneeded exemptions - #391
Merged
Conversation
Reverts ee0fbd3, which took both docs checks red. The listings were not stale: docs_check_signatures validates them against the headers' doxygen XML and passed on the commit before. It dropped four `operator&` overloads — the short-circuit arms, in the expected and the optional group alike — and `operator|`'s `just<void>` arm, duplicating four `some_optional` entries in their place; the six added exemptions name entities the coverage check already reaches, which it reports as unnecessary. Assisted-by: Claude:claude-opus-5
🤖 Augment PR SummarySummary: This PR fixes the docs CI gate by restoring the generated/reference operator listings and removing coverage exemptions that were added unnecessarily. Changes:
Technical Notes: Intended to make 🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docshas been red onmainsince the TYPE_ALGEBRA merge, which gates the Pages deploy — the published site stays stale until this lands.The last commit on that PR's branch (
ee0fbd35) took both docs checks red, and neither of its two stated goals holds:docs_check_signaturesvalidates them against the doxygen XML of the real headers, and it passed on the preceding commit. The change dropped fouroperator&overloads — the short-circuit arms-> std::remove_cvref_t<Rh>and-> std::remove_cvref_t<Lh>, which appear in theexpectedand theoptionalgroup alike — andoperator|'s-> ::fn::just<void>arm, duplicating foursome_optionalentries in their place.docs_check_coveragedid not need satisfying: it was already passing. The six added exemptions name entities the check reaches, and it reports each one as unnecessary.This restores the three files to their state before that commit, byte for byte.
Verified locally:
export_docsexits 0 through all six steps,docs_check_coverageanddocs_check_signaturesincluded.No new test is owed — the behaviour is gated by those two checks, which are what caught the regression.
Assisted-by: Claude:claude-opus-5