fix(providers): restore models removed by PR #58, add lemonade provider#60
Closed
fix(providers): restore models removed by PR #58, add lemonade provider#60
Conversation
- anthropic: restore claude-3-5-sonnet-20241022 (7 models, not 6) - xai: restore grok-2 and grok-2-mini (9 models, not 7) - ollama: restore llama3.2 (required by metering and merge-skip tests) - lemonade: add missing local provider (referenced in is_local_provider() and driver list)
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Contributor
Author
|
Wrong approach — old models were intentionally removed. Tests should be updated instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #58 (ollama catalog expansion) accidentally removed several models that CI tests depend on:
claude-3-5-sonnet-20241022was removed (6→7 models)grok-2andgrok-2-miniwere removed (7→9 models)llama3.2was removed (needed bytest_merge_skips_existingandtest_estimate_cost_with_catalog_local_zero_price_stays_zero)is_local_provider()and the driver list (test_build_router_providers_marks_lemonade_as_localfails)Fixes CI failures on main
test_build_router_providers_marks_lemonade_as_localtest_estimate_cost_with_catalog_local_zero_price_stays_zeromodel_catalog::tests::test_find_model_prefers_custom_over_builtinmodel_catalog::tests::test_merge_skips_existingmodel_catalog::tests::test_models_by_providermodel_catalog::tests::test_provider_model_countsmodel_catalog::tests::test_xai_models