Improve startup speeds in some situations by using find before chown #540
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change chown lines to fix delayed startup due to long running chown (issue librenms#524)
|
|
3 tasks
murrant
approved these changes
Jan 22, 2026
murrant
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change chown lines to fix delayed startup due to long running chown (issue #524)
I can't get the command proposed by @Zugschlus in issue #524 to work when testing in a controlled environment. What does work though:
-not \( -user librenms -group librenms \)This makes it a check for files NOT owned by user librenms AND group librenms, which is what I think we are trying to achieve.
As @murrant requested, I've created a pull request with this change
fixes #524