webOS: restore absolute mouse coords for menu/OSK hit-testing - #19277
Open
theromis wants to merge 1 commit into
Open
webOS: restore absolute mouse coords for menu/OSK hit-testing#19277theromis wants to merge 1 commit into
theromis wants to merge 1 commit into
Conversation
libretro#18432 made SDL mouse X/Y always relative so cores get deltas, but the menu reads RARCH_DEVICE_MOUSE_SCREEN and needs absolute position. Keep relative for RETRO_DEVICE_MOUSE and absolute for MOUSE_SCREEN so Magic Remote can click OSK keys again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#18432made SDL mouse X/Y always relative on webOS so cores receive deltas.RARCH_DEVICE_MOUSE_SCREENand need absolute coordinates for key hit-testing, so Magic Remote pointer clicks on the OSK missed.RETRO_DEVICE_MOUSEand absolute forMOUSE_SCREEN(same split as other input drivers).Test plan