Updating libchdr, crypto and libFLAC deps #952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Given the recent important updates to libchdr upstream, this should likely be redone. Who knows, might help the ARM issue too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So on my quest to fix the CHD v5 issue on an RK2020 this afternoon, I've updated the libchdr libFLAC and crypto dependancies to align with upstream. Everything still compiles cleanly and my Mac and armv8 builds worked just fine, albeit with the CHDv5 function not working on the armv8.
I'll submit another PR with the Makefile based solution to the v5 issue on ARM.