Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new binder API to retrieve currently running hooked target processes from the Xposed framework/service interface.
Changes:
- Introduce
getRunningTargets()to theIXposedServiceAIDL interface. - Add a new AIDL parcelable
HookedProcessto represent running process metadata. - Expose
getRunningTargets()on theXposedServiceclient wrapper.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| service/src/main/java/io/github/libxposed/service/XposedService.java | Adds a client-facing wrapper method calling the new binder API. |
| interface/src/main/aidl/io/github/libxposed/service/IXposedService.aidl | Extends the binder interface with getRunningTargets() returning List<HookedProcess>. |
| interface/src/main/aidl/io/github/libxposed/service/HookedProcess.aidl | Introduces a structured parcelable representing a hooked process (package/pid/uid/upToDate). |
Comments suppressed due to low confidence (2)
service/src/main/java/io/github/libxposed/service/XposedService.java:273
getRunningTargets()is a new public API but it lacks Javadoc, while the surrounding public methods inXposedServiceare documented. Please add a brief Javadoc describing what a “running target” is, whatHookedProcess.upToDatemeans, and what exceptions/caller expectations are.
@NonNull
public List<HookedProcess> getRunningTargets() {
try {
return mService.getRunningTargets();
} catch (RemoteException e) {
throw new ServiceException(e);
}
}
service/src/main/java/io/github/libxposed/service/XposedService.java:270
- This method is annotated
@NonNullbut returns the binder result directly without a null check. Since AIDL can returnnulllists, this can violate the nullness contract and lead to NPEs downstream; either enforce non-null by checking for null and throwing aServiceException, or mark the method@Nullable.
public List<HookedProcess> getRunningTargets() {
try {
return mService.getRunningTargets();
} catch (RemoteException e) {
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.