Skip to content

fix(gui): use official brand marks for commandcode and openai icons - #1074

Merged
Wibias merged 1 commit into
lidge-jun:devfrom
Wibias:fix/gui-provider-icon-fixes
Aug 5, 2026
Merged

fix(gui): use official brand marks for commandcode and openai icons#1074
Wibias merged 1 commit into
lidge-jun:devfrom
Wibias:fix/gui-provider-icon-fixes

Conversation

@Wibias

@Wibias Wibias commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • commandcode provider icon: commandcode was rendering with the fallback initial-letter tile because it had no icon alias. Added a dedicated commandcode-color.svg asset using the official Command Code brand mark (the ⌘ glyph in a rounded frame, brand purple #8C4EDD, sourced from the published commandcode.ai logo) and registered the commandcodecommandcode-color.svg alias plus the "Command Code" display name in g ui/src/provider-icons.ts.
  • OpenAI icon color: g ui/public/provider-icons/openai.svg used the wrong purple #412991; corrected to the official OpenAI brand green #10A37F.

Verification

  • bun scripts/test.ts provider-workspace-data.test.ts — 46 pass / 0 fail, including a new assertion that providerIconSrc("commandcode") resolves to /provider-icons/commandcode-color.svg and its display name is "Command Code".
  • bun x tsc --noEmit — clean.

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed.
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults.

Summary by CodeRabbit

  • New Features

    • Added branded icon and display name support for the Command Code provider.
  • Tests

    • Added coverage to verify the Command Code provider uses the correct icon and label.

- add a dedicated commandcode-color.svg (Command Code ⌘ mark in brand
  purple #8C4EDD) and register the commandcode provider alias plus its
  "Command Code" display name, replacing the fallback initial tile
- correct openai.svg from the wrong purple #412991 to the official
  OpenAI green #10A37F

Co-authored-by: CommandCodeBot <noreply@commandcode.ai>
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

⚠️ UI screenshot required

This pull request mentions gui in its title or description, so it is treated as a GUI change.

@Wibias Please add a screenshot of the UI change to the description — drag and drop the image into the description editor, or paste a markdown image such as ![Screenshot](https://example.com/after.png). The check re-runs automatically once the description is edited.

Automatic draft conversion failed (token cannot change draft status). Please convert this pull request to a draft manually. The required enforce-target check will keep failing until every issue above is resolved.

@github-actions
github-actions Bot marked this pull request as draft August 5, 2026 18:11
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

Deterministic PR hygiene checks passed.

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The change adds Command Code to the provider icon alias map with its colored SVG asset and display name. Tests verify the icon path and the Command Code label.

Changes

Command Code icon support

Layer / File(s) Summary
Command Code icon registration and validation
gui/src/provider-icons.ts, tests/provider-workspace-data.test.ts
The provider icon map registers commandcode with commandcode-color.svg and the Command Code display name. Tests verify both values.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

Suggested reviewers: ingwannu, lidge-jun

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the GUI branding changes for the Command Code and OpenAI icons.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the bug Something isn't working label Aug 5, 2026
@Wibias
Wibias marked this pull request as ready for review August 5, 2026 18:12
@Wibias
Wibias merged commit 80e4075 into lidge-jun:dev Aug 5, 2026
19 of 24 checks passed
@Wibias
Wibias deleted the fix/gui-provider-icon-fixes branch August 5, 2026 18:12

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@gui/src/provider-icons.ts`:
- Line 67: Update formatProviderDisplayName and its provider-name configuration
so commandcode is included in PROVIDER_DISPLAY_NAME_KEYS and resolved through
the existing locale lookup path instead of the hardcoded PROVIDER_DISPLAY_NAMES
fallback. Add the matching commandcode translation to each locale resource, and
update the related test to assert the localized key path rather than only
englishT.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: db477768-beb7-4791-a61a-93147106c103

📥 Commits

Reviewing files that changed from the base of the PR and between 0e92714 and b143984.

⛔ Files ignored due to path filters (2)
  • gui/public/provider-icons/commandcode-color.svg is excluded by !**/*.svg
  • gui/public/provider-icons/openai.svg is excluded by !**/*.svg
📒 Files selected for processing (2)
  • gui/src/provider-icons.ts
  • tests/provider-workspace-data.test.ts

Comment thread gui/src/provider-icons.ts
"cloudflare-workers-ai": "Cloudflare Workers AI",
cline: "Cline",
"cline-pass": "ClinePass",
commandcode: "Command Code",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Route Command Code through the locale files.

formatProviderDisplayName returns PROVIDER_DISPLAY_NAMES[key] directly when no localized key exists. This hardcoded value prevents locale-specific translations for commandcode.

Add commandcode to PROVIDER_DISPLAY_NAME_KEYS and define the matching value in the locale resources. Update the test to verify the localized key path, not only englishT.

As per path instructions, user-visible strings must go through i18n locale files rather than hardcoded text.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@gui/src/provider-icons.ts` at line 67, Update formatProviderDisplayName and
its provider-name configuration so commandcode is included in
PROVIDER_DISPLAY_NAME_KEYS and resolved through the existing locale lookup path
instead of the hardcoded PROVIDER_DISPLAY_NAMES fallback. Add the matching
commandcode translation to each locale resource, and update the related test to
assert the localized key path rather than only englishT.

Source: Path instructions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant