[WRONG BRANCH] chore: port #1002 into maintainer takeover branch - #1237
[WRONG BRANCH] chore: port #1002 into maintainer takeover branch#1237Wibias wants to merge 5 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
the
chore
|
✅ Deterministic PR hygiene checks passed. |
github-actions
Bot
changed the title
⏳ DRAFT
What to do
Its title has been prefixed with |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b3018a3e8b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| export function visionReasoningLadder(models: ModelInfo[], modelId: string): VisionReasoning[] { | ||
| const model = models.find(m => m.id === modelId); | ||
| const ladder = model?.reasoningEfforts; | ||
| if (!ladder || ladder.length === 0) return [...VISION_REASONING_LEVELS]; |
There was a problem hiding this comment.
When the selected vision model is a native OpenAI row, /api/models omits reasoningEfforts, so this fallback exposes every level even though the bundled catalog limits models such as gpt-5.4-mini and gpt-5.5 to low through xhigh. Selecting max is therefore persisted and forwarded unchanged by describeImage, causing the sidecar request to fail instead of describing the image. Include native reasoning metadata in the management rows or use a capability-aware fallback rather than treating missing metadata as full support.
AGENTS.md reference: gui/AGENTS.md:L10-L10
Useful? React with 👍 / 👎.
| <Select | ||
| value={visionReasoning} | ||
| options={visionReasoningOptionsFor(visionLadder, visionReasoning).map(value => ({ value, label: value }))} | ||
| onChange={reasoning => { void saveSidecar({ vision: { reasoning: reasoning as typeof visionReasoning } }); }} | ||
| disabled={!sidecar || sidecarSaving} |
There was a problem hiding this comment.
When the selected or automatic vision backend is Anthropic, this selector remains enabled and saves a reasoning value even though the Anthropic executor never reads it. The dashboard consequently presents a successfully saved control that has no effect on requests; gate the selector to the effective OpenAI backend or connect it to an Anthropic thinking setting.
AGENTS.md reference: gui/AGENTS.md:L10-L10
Useful? React with 👍 / 👎.
2 participants
Internal maintainer port step for #1002. This merges the original contributor branch into the maintainer-owned takeover branch, which was cut from current
dev, so the original commits/attribution are preserved before maintainer hardening.This targets the takeover branch only and is not the final user-facing PR.