fix(lab): CL-02 post-merge hardening - #1343
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe PR hardens Compatibility Lab ledger replay, artifact publication and validation, sensitive-evidence purging, filesystem-path detection, conformance timestamps, and projection behavior. It adds regression coverage for these changes. ChangesCompatibility Lab hardening
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
Default sensitive purge wipes export/scratch without event or artifact ids. Keep the empty-target reject for ledger/sqlite/artifact-only tombstones.
Broaden POSIX path admission, convert contract put failures to artifact_mismatch, clarify CL-02 accepted head, and remove duplicate observation keys.
Cover '/' and '/tmp//secret' in ledger admission while keeping URL '//' prefixes allowed.
Summary
Post-merge CL-02 hardening after PR #1333 merged at
025c37916225dd685d9217e5b40190600f06d278and a final CodeRabbit batch landed immediately before merge.This PR remains CL-02-only. It does not start CL-03 and does not change frozen CL-00 semantics.
Fixes in this follow-up
artifact_mismatchconfig=/home/<user>/...before ledger admissionPURGE_ACTIONS, includingexportScenarioRunResult.startedAt/completedAttyped runner output and removes the CL-02 cast-based timestamp seamRegression coverage
New focused tests cover:
maxAgeMscapability_absence_control→UNSUPPORTEDprojection path using synthetic evidence, without modifying the V1 authorityBase
dev025c37916225dd685d9217e5b40190600f06d278fix/cl-02-post-merge-hardeningValidation
Keep this PR draft until the current cross-platform run is green and the post-merge review findings are reconciled.
Summary by CodeRabbit
Bug Fixes
Tests
Documentation