-
Notifications
You must be signed in to change notification settings - Fork 665
feat(lab): CL-05 compatibility matrix UI #1384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Wibias
merged 16 commits into
lidge-jun:dev
from
Wibias:feat/cl-05-compatibility-matrix-ui
Aug 10, 2026
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
ceac431
feat(lab): CL-05 compatibility matrix UI
Wibias 38ce440
fix(gui): move CL-05 compatibility matrix into Models tab
Wibias 2a159b8
docs(devlog): record CL-05 validation after Models tab move
Wibias ddcc710
docs(devlog): record CL-05 implementation head on stack status
Wibias 4805477
docs(devlog): add CL-05 compatibility matrix GUI screenshots
Wibias 9c98a65
fix(lab): address CL-05 review findings
Wibias adf28fc
fix(lab): use typed contract failures in CL-05 GUI
Wibias 2dead29
fix(lab): keep CL-05 pagination state effect-safe
Wibias a381a9d
test(lab): assert typed CL-05 contract failures
Wibias 716118e
fix(lab): make appended-page narrowing explicit
Wibias 8a6331c
test(lab): cover bounded pagination truncation
Wibias b460adf
fix(lab): distinguish pagination truncation from contract failure
Wibias cdf5765
docs(lab): align CL-05 validation record with review
Wibias 68edcd4
test(cli): document Compatibility Lab parity
Wibias 594492c
test(cli): restore provider context assertion
Wibias d717984
test(lab): assert pagination cursor progression
Wibias File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
71 changes: 71 additions & 0 deletions
71
devlog/_plan/260807_compatibility_lab/005_cl05_compatibility_matrix_ui.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| # CL-05 implementation record - Compatibility Matrix UI | ||
|
|
||
| ## Programme position | ||
|
|
||
| - **Phase:** CL-05 (read-only GUI) | ||
| - **Starting `upstream/dev` SHA:** `d517161aeaa3a974ad3c0360ff0c97b03b4c4520` (merge #1378 / CL-04) | ||
| - **Branch:** `feat/cl-05-compatibility-matrix-ui` | ||
| - **PR:** DRAFT → `lidge-jun/opencodex:dev` ([#1384](https://github.com/lidge-jun/opencodex/pull/1384)) | ||
| - **CL-06:** not started | ||
|
|
||
| ## Scope delivered | ||
|
|
||
| ### GUI (`gui/src/pages/`) | ||
|
|
||
| - **Models → Compatibility tab** at `#models/compatibility` (not a standalone sidebar page) | ||
| - Legacy `#lab` hash redirects to `#models/compatibility` | ||
| - `CompatibilityMatrix.tsx` - read-only verdict matrix over CL-04 management APIs | ||
| - `compatibility-matrix-api.ts` - bounded paginated fetch helpers for `/api/lab/status`, `/api/lab/verdicts`, `/api/lab/subjects`, and detail reads | ||
| - `compatibility-matrix-shared.ts` - fail-closed DTO parsing, matrix grouping, and filters | ||
| - `styles-compatibility-matrix.css` - scrollable matrix + detail pane | ||
| - Compatibility Lab copy localized for all seven locales (`en`, `de`, `ko`, `zh`, `ru`, `ja`, `tr`) | ||
| - Component/layout tests in `gui/tests/compatibility-lab.test.tsx` and `gui/tests/compatibility-matrix-layout.test.ts` | ||
|
|
||
| ### Behaviour | ||
|
|
||
| - Projection status cards (subjects, verdicts, observations, events, built-at) | ||
| - Subject × evidence-layer matrix with per-suite verdict badges | ||
| - Server-side verdict filters for evidence layer, verdict, and an exact Subject-ID picker, with paginated "Load more" | ||
| - Verdict detail pane (subject, all paginated observations, bounded evidence events, artifact metadata only) | ||
| - Verdict selection is presentation state only; it never changes matrix filters or pagination identity | ||
| - Empty/unavailable/incompatible projection states via existing data-surface contract; malformed successful API payloads fail closed as load errors | ||
| - Lazy mount with `active` / hidden-panel gating inside Models workspace | ||
| - No probe execution, projection rebuild, or evidence mutation | ||
|
|
||
| ## Review remediation | ||
|
|
||
| The follow-up review pass addresses all validated CodeRabbit findings plus the independent lifecycle findings found while reviewing #1384: | ||
|
|
||
| - legacy `#lab` cold-load page alignment and delimiter-aware regression coverage | ||
| - repeated-cursor contract guards plus explicit truncation when advancing pagination reaches the browser-side safety cap | ||
| - strict verdict/detail DTO validation and malformed-200 handling | ||
| - bounded, partial-failure-tolerant event/artifact enrichment | ||
| - detail-selection and load-more stale-response protection | ||
| - first-page refresh/poll invalidation of appended cursor pages | ||
| - exact Subject-ID picker semantics instead of misleading free-text search | ||
| - localized closed-value labels and neutral evidence-event wording | ||
| - real button semantics for verdict-detail selection | ||
| - inactive-panel, selection/filter, pagination, localization, and routing regression coverage | ||
| - focused `compatibility-pagination-cap.test.ts` coverage proving a large advancing dataset is truncated rather than mislabeled as a broken contract | ||
| - Models-tab layout test updated from the removed standalone App/sidebar architecture | ||
|
|
||
| ## Validation recorded before review remediation | ||
|
|
||
| - `bun x tsc --noEmit` - passed | ||
| - `bun test tests/lab-read-surfaces.test.ts tests/models-workspace-tabs.test.ts` - 33/33 passed | ||
| - `cd gui && bun test tests/compatibility-lab.test.tsx tests/models-workspace-panels.test.tsx` - 29/29 passed | ||
| - `cd gui && bun test tests/compatibility-matrix-layout.test.ts` - 2/2 passed in the full GUI gate | ||
| - `bun run lint:gui && bun run doctor:gui && bun run build:gui && bun run privacy:scan` - passed | ||
|
|
||
| The latest pagination-cap remediation adds `gui/tests/compatibility-pagination-cap.test.ts` and requires a fresh CI pass before acceptance; the earlier results above are retained only as baseline evidence. | ||
|
|
||
| ## Acceptance blockers | ||
|
|
||
| - Fresh cross-platform CI on the remediation head must be green | ||
| - Independent acceptance review not performed | ||
|
|
||
| ## Out of scope (confirmed) | ||
|
|
||
| - CL-06 routing profile compatibility fields, CL-07 fabric, CL-08 shadow/automatic/public publish | ||
| - New management APIs or CLI changes (CL-04 read surfaces are sufficient) | ||
| - Probe execution, projection rebuild triggers, raw artifact download in GUI | ||
Binary file added
BIN
+102 KB
...g/_plan/260807_compatibility_lab/screenshots/cl-05/01-matrix-populated-dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+75.6 KB
...n/260807_compatibility_lab/screenshots/cl-05/02-projection-unavailable-dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+80.3 KB
...g/_plan/260807_compatibility_lab/screenshots/cl-05/03-projection-empty-dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+147 KB
devlog/_plan/260807_compatibility_lab/screenshots/cl-05/04-verdict-detail-dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+54 KB
devlog/_plan/260807_compatibility_lab/screenshots/cl-05/05-matrix-narrow-dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.