test(images): cover bodyless 304 content length - #1389
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe change adds regression coverage for bodyless ChangesBodyless response handling
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
Wibias
left a comment
There was a problem hiding this comment.
Reviewed the final head. No actionable findings.
The focused regression now covers the standards-valid case that motivated #1386: a bodyless HTTP 304 with a representation Content-Length above the image relay cap. It directly verifies readImageResponseBytes() treats the response as zero bytes and does not flag it as oversized. Scope is test-only, the PR is mergeable, and Cross-platform CI plus React Doctor are green.
From a code-review perspective, this is ready to merge.
Summary
Content-Lengthlarger than the image relay cap.Why
#1386 correctly fixed bodyless responses before evaluating
Content-Length, but its integration regression used204 + Content-Length. A 304 response is the standards-valid case whereContent-Lengthcan describe the selected representation while the response itself has no body.Scope
Test-only. No production behavior changes.
Validation
devafter fix(images): preserve bodyless responses with size headers #1386 and fix(providers): bound quota response parsing #1387.Summary by CodeRabbit
Bug Fixes
304responses with oversizedContent-Lengthheaders.Tests