Skip to content

fix(adapters): neutralize Codex CLI 0.145 identity wording - #638

Merged
Wibias merged 2 commits into
lidge-jun:devfrom
Wibias:fix/622-identity-neutralize
Jul 29, 2026
Merged

fix(adapters): neutralize Codex CLI 0.145 identity wording#638
Wibias merged 2 commits into
lidge-jun:devfrom
Wibias:fix/622-identity-neutralize

Conversation

@Wibias

@Wibias Wibias commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Expand neutralizeIdentity to cover Codex CLI 0.145.0's You are Codex, an agent based on GPT-5 variant (and optional GPT-5.x suffix) via a narrow regex.
  • Leave unrelated Codex mentions unchanged.

Test plan

  • bun test tests/identity-neutralize.test.ts
  • CI green

Closes #622

Summary by CodeRabbit

  • Bug Fixes
    • Improved handling of Codex GPT-5 identity messages.
    • Ensured supported identity wording is consistently replaced with a neutral disclaimer.
    • Preserved unrelated system text, including messages describing pull request review assistance.

@github-actions github-actions Bot added the bug Something isn't working label Jul 28, 2026
@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@Wibias, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 51 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 37f780cc-8e5a-4570-bca0-5dc46d0aacd0

📥 Commits

Reviewing files that changed from the base of the PR and between cea531d and b9e77e7.

📒 Files selected for processing (2)
  • src/adapters/identity.ts
  • tests/identity-neutralize.test.ts
📝 Walkthrough

Walkthrough

Changes

Identity neutralization

Layer / File(s) Summary
GPT-5 identity matching and validation
src/adapters/identity.ts, tests/identity-neutralize.test.ts
Adds a Codex GPT-5 identity variant and narrowly scoped regex matching, updates neutralizeIdentity to replace known variants, and tests both replacement and preservation of unrelated text.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: ingwannu, lidge-jun

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly reflects the main change: widening Codex CLI identity neutralization in the adapters layer.
Linked Issues check ✅ Passed src/adapters/identity.ts now neutralizes both required Codex GPT-5 variants, and tests cover preservation of unrelated text.
Out of Scope Changes check ✅ Passed The changes stay focused on identity neutralization in the adapter and its tests, with no unrelated feature work.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@Wibias

Wibias commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review
@coderabbitai review

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown

@Wibias I’ll review the changes in #638, with particular attention to the regex scope and identity-neutralization test coverage.

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

coderabbitai[bot]

This comment was marked as resolved.

@Wibias Wibias linked an issue Jul 28, 2026 that may be closed by this pull request
2 tasks
chatgpt-codex-connector[bot]

This comment was marked as resolved.

@Wibias

Wibias commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator Author

@coderabbitai: addressed in b9e77e7 — regex now consumes full GPT-5(.N)* version segments.

@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo '== Commit summary =='
git show --no-ext-diff --format=fuller --stat b9e77e77 --

echo
echo '== Changed identity implementation =='
ast-grep outline src/adapters/identity.ts --items all || true
git show --no-ext-diff --format= --unified=80 b9e77e77 -- src/adapters/identity.ts

echo
echo '== Changed identity tests =='
ast-grep outline tests/identity-neutralize.test.ts --items all || true
git show --no-ext-diff --format= --unified=100 b9e77e77 -- tests/identity-neutralize.test.ts

echo
echo '== Current relevant declarations and assertions =='
rg -n -C 5 'CODEX_GPT5|GPT-5|neutralizeIdentity|NEUTRAL_IDENTITY_LINE' \
  src/adapters/identity.ts tests/identity-neutralize.test.ts

Length of output: 20605


@Wibias Confirmed. In src/adapters/identity.ts Line 28, (?:\.[0-9]+)* now consumes all numeric suffix segments before the terminal period, so identities such as GPT-5.4.1. are replaced as one complete sentence rather than leaving 1. behind. tests/identity-neutralize.test.ts Line 34 covers that exact multi-segment case.

@Wibias
Wibias merged commit 868a9c4 into lidge-jun:dev Jul 29, 2026
19 of 21 checks passed
Wibias added a commit that referenced this pull request Jul 29, 2026
TS oracle on dev2-go. Go NeutralizeIdentity port tracked separately. Source: 868a9c4 (#638).
@Wibias

Wibias commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator Author

Transition workflow completed

  1. Merged into dev: 868a9c43 (fix(adapters): neutralize Codex CLI 0.145 identity wording #638)
  2. Carried onto dev2-go: fix(adapters): carry Codex identity neutralize onto dev2-go (#638) #665
  3. Go port: needed — Go still exact-matches the old GPT-5 line only. Tracking issue with needs-go-port follows in the next comment if not linked here.

@Wibias

Wibias commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator Author

Go port tracking: #666

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Identity neutralization misses current Codex CLI wording

1 participant