fix(service): compare Task Scheduler Arguments after XML decode - #641
fix(service): compare Task Scheduler Arguments after XML decode#641Wibias wants to merge 2 commits into
Conversation
|
Warning Review limit reached
Next review available in: 51 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@codex review |
|
✅ Action performedReview finished.
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 07e637491e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (taskXmlHasPrefixedTag(xml, tag)) return false; | ||
| const count = taskXmlElementCount(xml, tag); | ||
| if (count !== 1) return false; | ||
| const raw = new RegExp(`<${tag}(?:\\s[^>]*?)?>\\s*([^<]*?)\\s*<\\/${tag}>`, "i").exec(xml)?.[1]; |
There was a problem hiding this comment.
If an externally modified task contains leading or trailing whitespace in <Command> or <Arguments>, the surrounding \s* consumes that whitespace before comparison, so windowsTaskRegistrationHealthy() reports an exact match even though the registered command text differs and a whitespace-prefixed executable path may not launch. Capture the complete element text, decode it without trimming, and add a focused regression case for whitespace around the action value.
AGENTS.md reference: AGENTS.md:L93-L95
Useful? React with 👍 / 👎.
|
You have reached your Codex usage limits. You can see your limits in the Codex usage dashboard. |
1 participant
Summary
<Arguments>/<Command>by decoding XML entities once, matching Windows Task Scheduler's unescaped export (distinct from fix(windows): startup safety falsely marks healthy scheduler service stale #432).Test plan
bun test tests/service.test.ts -t '#608'Closes #608