-
Notifications
You must be signed in to change notification settings - Fork 652
stack 3/7: carry six contributor bug fixes with authorship intact #953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
c233a7c
fix(claude): keep a marker for tool_result document blocks
DevMello 6dbd972
fix(google): fail closed on MALFORMED_FUNCTION_CALL without a call part
DevMello 528cfc1
fix(claude): separate reasoning summary parts in streamed thinking
DevMello 0bb2820
fix(compact): report upstream usage for native compact turns
DevMello 02ca79a
fix(responses): close passthrough streams at terminal events
L14nY1Wang a4c78b2
fix(kiro): round-trip the redactedContent reasoning blob
mushikingh 6cda4a1
fix(kiro): defer the reasoning envelope until the turn's items close
mushikingh 9664abd
test(kiro): make the budget regression actually observe the retained …
mushikingh fac1521
Merge remote-tracking branch 'origin/dev' into merge953
lidge-jun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Flush the Kiro blob on every terminal path.
Lines 1100-1102 flush
pendingKiroRedactedonly fordone. Theincomplete,error, adapter-EOF, and stall-timeout paths do not flush or release it. A stream that receiveskiro_redacted_reasoningand then terminates abnormally loses the replay state. It also leaves the retained blob charged in an externalTranslatorBudget.Call
flushKiroRedactedReasoning()after closing open output items in every terminal path, before emitting the terminal Responses event. Add regression tests forincompleteanderrorafter a Kiro blob. This aligns streaming behavior with batch finalization at Lines 1717-1725.Also applies to: 921-926, 1100-1102
🤖 Prompt for AI Agents