Set the SigHashType of htlc signatures w/ anchors to SinglePlusAnyoneCanPay

[ksedgwic]

Survey of Needed Unit Tests

• channelmonitor.rs

  • tests:
    • test_claim_txn_weight_computation

• keysinterface.rs

  • InMemorySigner
    • sign_counterparty_commitment
    • sign_counterparty_htlc_transaction

• package.rs

  • PackageSolvingData::finalize_input:
    • CounterpartyOfferedHTLCOutput
    • CounterpartyReceivedHTLCOutput

• chan_utils.rs

  • TrusTrustedCommitmentTransaction
    • get_htlc_sigs
    • get_signed_htlc_tx

• channel.rs

  • commitment_signed

• enforcing_trait_impls.rs

  • EnforcingSigner:
    • sign_holder_commitment_and_htlcs

Related Issue and Unit Test Implications

• chan_utils.rs
  • hide HTLC_{SUCCESS,TIMEOUT}_TX_WEIGHT
    • Channel<Signer>:
      • build_commitment_transaction
      • get_inbound_pending_htlc_stats
      • get_outbound_pending_htlc_stats
      • next_local_commit_tx_fee_msat
      • next_remote_commit_tx_fee_msat
      • update_add_htlc
      • send_htlc
      • tests::test_timeout_vs_success_htlc_dust_limit
    • functional_tests.rs:
      • tests::test_chan_reserve_dust_inbound_htlcs_outbound_chan
      • tests::do_test_max_dust_htlc_exposure

[devrandom]

I also reviewed all uses of SigHashType::All, and it seems we got all the relevant ones.

[devrandom]

Prefer `.iter()` in that case

…

On Sun, Jan 2, 2022, 17:19 Ken Sedgwick ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In lightning/src/chain/package.rs <#5 (comment)> : > @@ -1027,6 +1047,8 @@ mod tests { let package = PackageTemplate::build_package(txid, 0, revk_outp, 0, true, 100); // (nVersion (4) + nLocktime (4) + count_tx_in (1) + prevout (36) + sequence (4) + script_length (1) + count_tx_out (1) + value (8) + var_int (1)) * WITNESS_SCALE_FACTOR // + witness marker (2) + WEIGHT_REVOKED_OUTPUT - assert_eq!(package.package_weight(&Script::new()), (4 + 4 + 1 + 36 + 4 + 1 + 1 + 8 + 1) * WITNESS_SCALE_FACTOR + 2 + WEIGHT_REVOKED_OUTPUT as usize); + for opt_anchors in &[false, true] { You do for rust-1.41.0: ```error[E0277]: [bool; 2] is not an iterator 63 --> lightning/src/chain/package.rs:1050:22 64 | 65 1050 | for opt_anchors in [false, true] { 66 | ^^^^^^^^^^^^^ borrow the array with `&` or call `.iter()` on it to iterate over it 67 | 68 = help: the trait `std::iter::Iterator` is not implemented for `[bool; 2]` 69 = note: arrays are not iterators, but slices like the following are: `&[1, 2, 3]` 70 = note: required by `std::iter::IntoIterator::into_iter` 71 — Reply to this email directly, view it on GitHub <#5 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAA2EWFPIB4XCD3ESWHTTIDUUCCLHANCNFSM5K5IGVOA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because your review was requested.Message ID: ***@***.***>

[ksedgwic]

Prefer .iter() in that case

Well, you still have to have the deref *opt_anchors, so the &[] is less chars ... but ok

nm - I figured it out

[devrandom]

ACK