Handle fallible per commitment point for RAA#3150
Merged
TheBlueMatt merged 6 commits intolightningdevkit:mainfrom Jul 16, 2024
Merged
Handle fallible per commitment point for RAA#3150TheBlueMatt merged 6 commits intolightningdevkit:mainfrom
TheBlueMatt merged 6 commits intolightningdevkit:mainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on
#3149.This is the first PR to handle async
get_per_commitment_point, and only handles theErrcases for retrieving revoke_and_ack. We still need to handle this during funding (#3109) and channel reestablish (no PR yet) in upcoming PRs.For all async signing, we try to go about our normal business, and when we fail to get a signature from our signer, we pause our channel, and only unpause upon the user calling
ChannelManager::signer_unblocked. With thesigner_pending_revoke_and_ackflag being added in the prereq PR, we simply set the flag and allowget_last_revoke_and_ackto return anOption. We also make sure that in cases where we must send RAA then CS, that we defer sending a CS (even if it's available) until the signature for the RAA is unblocked.