Skip to content

Handle fallible per commitment point for RAA#3150

Merged
TheBlueMatt merged 6 commits intolightningdevkit:mainfrom
alecchendev:2024-06-async-commit-point-raa
Jul 16, 2024
Merged

Handle fallible per commitment point for RAA#3150
TheBlueMatt merged 6 commits intolightningdevkit:mainfrom
alecchendev:2024-06-async-commit-point-raa

Conversation

@alecchendev
Copy link
Copy Markdown
Contributor

@alecchendev alecchendev commented Jun 30, 2024

Builds on #3149.

This is the first PR to handle async get_per_commitment_point, and only handles the Err cases for retrieving revoke_and_ack. We still need to handle this during funding (#3109) and channel reestablish (no PR yet) in upcoming PRs.

For all async signing, we try to go about our normal business, and when we fail to get a signature from our signer, we pause our channel, and only unpause upon the user calling ChannelManager::signer_unblocked. With the signer_pending_revoke_and_ack flag being added in the prereq PR, we simply set the flag and allow get_last_revoke_and_ack to return an Option. We also make sure that in cases where we must send RAA then CS, that we defer sending a CS (even if it's available) until the signature for the RAA is unblocked.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants