go.mod: update lnd to v0.21.0-beta.rc1#271
Closed
hieblmi wants to merge 13 commits intolightninglabs:lnd-21-0from
Closed
go.mod: update lnd to v0.21.0-beta.rc1#271hieblmi wants to merge 13 commits intolightninglabs:lnd-21-0from
hieblmi wants to merge 13 commits intolightninglabs:lnd-21-0from
Conversation
During planned termination, conn.Close() can return ErrClientConnClosing from gRPC package. This is expected and should not be logged as an error. Downgrade that case to debug so logs stay clean during shutdown. Original log line: [ERR] LNDC: Error closing lnd connection: rpc error: code = Canceled desc = grpc: the client connection is closing
lndclient: silence expected close error on shutdown
go.mod: bump lnd to v0.20.1-beta, go to 1.25.5
Marshal explicit route hints in lightningClient.AddInvoice so the standard invoice path matches AddHoldInvoice. Add regression coverage for direct AddInvoice route hint encoding and for route hint parity between AddInvoice and AddHoldInvoice.
Set FallbackAddr on the standard AddInvoice RPC request so the lightning client preserves explicit on-chain fallback addresses. Extend the existing invoice tests with direct AddInvoice coverage and parity checks against AddHoldInvoice.
Set IsAmp on the standard AddInvoice RPC request so callers can request AMP invoices through lightningClient.AddInvoice. Extend the existing AddInvoice unit test to assert AMP invoice requests preserve the flag on the outgoing RPC payload.
Stop forwarding Hash on the standard AddInvoice path and warn when Hash or HodlInvoice are provided, since callers should use InvoicesClient.AddHoldInvoice for hold invoices. Extend the existing AddInvoice test to assert the standard invoice request omits hold-invoice-only arguments.
Translate BlindedPathCfg into the standard AddInvoice RPC by setting IsBlinded and forwarding MinNumPathHops as the compatible NumHops override. Warn when non-overlapping blinded path settings are provided, and extend the AddInvoice unit test to assert blinded invoice requests preserve the translated RPC fields.
Warn when AddHoldInvoice is called with Amp or BlindedPathCfg, since the hold-invoice RPC cannot represent those inputs. Add coverage to document that the wrapper still forwards the supported request fields unchanged when those unsupported inputs are present.
Preserve AddInvoiceData fields across invoice wrappers
djkazic
approved these changes
Apr 23, 2026
|
Needs a |
|
Failing to build. Smells like a replace that's needed maybe? https://github.com/lightninglabs/lndclient/actions/runs/24836441760/job/72697959351?pr=271 |
bhandras
reviewed
Apr 23, 2026
Member
There was a problem hiding this comment.
As 0.21 is still RC, according to branching rules we want this in the lnd-21-0 branch and not master (which always points to the last stable release). So once 0.21 is released we'll merge lnd-21-0 into master and open lnd-22-0 for development.
Contributor
Author
|
closing in favor of #272 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.