-
Notifications
You must be signed in to change notification settings - Fork 123
workflow: replace swapserverrpc in lit-setup
#1061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workflow: replace swapserverrpc in lit-setup
#1061
Conversation
In order for the LiT CI jobs to use the `swapserverrpc` protos that exist on the latest `master` version of the `loop` repo, we need to update the `lit-setup` action to replace the litd `swapserverrpc` dependency with the latest version that exists in the `loop` repo.
Summary of ChangesHello @ViktorT-11, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the lit-setup GitHub Action to replace the swapserverrpc dependency with the local version from the loop repository. The change is correct and necessary for the LiT CI jobs. I've included a suggestion to refactor the dependency replacement commands for sub-modules into a loop to improve the script's maintainability.
| go mod edit -replace=github.com/lightninglabs/loop/looprpc=../looprpc | ||
| go mod edit -replace=github.com/lightninglabs/loop/swapserverrpc=../swapserverrpc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that there are multiple sub-modules being replaced, you could improve maintainability by refactoring these repeated go mod edit -replace commands into a loop. This would make it easier to add or remove sub-module replacements in the future.
For example:
for mod in looprpc swapserverrpc; do
go mod edit -replace="github.com/lightninglabs/loop/$mod=../$mod"
doneThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
looprpc should also be replaced.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its already replaced in the line above.
hieblmi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fix @ViktorT-11
In order for the LiT CI jobs to use the
swapserverrpcprotos that exist on the latestmasterversion of thelooprepo, we need to update thelit-setupaction to replace the litdswapserverrpcdependency with the latest version that exists in thelooprepo.