Skip to content

Conversation

@ViktorT-11
Copy link
Contributor

In order for the LiT CI jobs to use the swapserverrpc protos that exist on the latest master version of the loop repo, we need to update the lit-setup action to replace the litd swapserverrpc dependency with the latest version that exists in the loop repo.

In order for the LiT CI jobs to use the `swapserverrpc` protos that
exist on the latest `master` version of the `loop` repo, we need to
update the `lit-setup` action to replace the litd `swapserverrpc`
dependency with the latest version that exists in the `loop` repo.
@gemini-code-assist
Copy link

Summary of Changes

Hello @ViktorT-11, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the lit-setup GitHub Action to ensure that the Continuous Integration (CI) environment for Lightning Terminal (LiT) correctly uses the most recent swapserverrpc protocol definitions. By explicitly replacing the swapserverrpc dependency with the version found in the loop repository's master branch, this change prevents potential compatibility issues and ensures that CI jobs operate with the latest required components.

Highlights

  • CI Workflow Update: The lit-setup GitHub Action has been updated to correctly resolve the swapserverrpc dependency for LiT CI jobs.
  • Dependency Management: A go mod edit -replace directive was added for github.com/lightninglabs/loop/swapserverrpc to ensure the latest protos from the loop repository are used.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the lit-setup GitHub Action to replace the swapserverrpc dependency with the local version from the loop repository. The change is correct and necessary for the LiT CI jobs. I've included a suggestion to refactor the dependency replacement commands for sub-modules into a loop to improve the script's maintainability.

Comment on lines 22 to +23
go mod edit -replace=github.com/lightninglabs/loop/looprpc=../looprpc
go mod edit -replace=github.com/lightninglabs/loop/swapserverrpc=../swapserverrpc

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Now that there are multiple sub-modules being replaced, you could improve maintainability by refactoring these repeated go mod edit -replace commands into a loop. This would make it easier to add or remove sub-module replacements in the future.

For example:

for mod in looprpc swapserverrpc; do
  go mod edit -replace="github.com/lightninglabs/loop/$mod=../$mod"
done

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

looprpc should also be replaced.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its already replaced in the line above.

@hieblmi hieblmi requested review from hieblmi and starius December 16, 2025 19:55
Copy link
Collaborator

@hieblmi hieblmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix @ViktorT-11

@hieblmi hieblmi merged commit 2ed9e5b into lightninglabs:master Dec 17, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants