Skip to content

Breaking changes to bring tracer up to spec with latest API #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
ishg wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Breaking changes to bring tracer up to spec with latest API #51

ishg wants to merge 2 commits into from

Conversation

@ishg
Copy link

@ishg ishg commented May 6, 2020 •
edited
Loading

This tracer needs a lot of ❤️ Based on a first pass, adding a checklist of items that need to be done. Lots of breaking changes.

  • Remove older copy of opentracing api
  • Update classes to implement the actual OpenTracing PHP API
  • Implement SpanContext interface
  • Add getContext() to Span
  • Add overwriteOperationName() to Span
  • Update Inject in Tracer to use SpanContext instead of Span
  • Add Extract method in Tracer
  • Add support for B3/Stack Propagator
  • Implement Scope interface
  • Implement ScopeManager interface
  • Update a lot of tracer dev dependencies (phpunit, etc)
  • Update documentation to be compatible with OpenTracing Spec
  • Update PHP Version with compatble OpenTracing Version in CircleCI

@ishg ishg marked this pull request as draft May 6, 2020 23:07
@andrewhsu
Copy link

andrewhsu commented May 11, 2020

Can you put the min PHP version required for this change to go in to weigh whether this is ok for users?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

help wanted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ishg @andrewhsu