Skip to content

Disable dynamic type casts #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
giljulio wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Disable dynamic type casts #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions analysis_options.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,7 @@ include: package:flutter_lints/flutter.yaml

# Additional information about this file can be found at
# https://dart.dev/guides/language/analysis-options

linter:
rules:
- avoid_dynamic_calls
4 changes: 2 additions & 2 deletions lib/src/persister/disk_volt_persister.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,10 +187,10 @@ class FileVoltPersistor implements VoltPersistor {
.first);

final metadataString = await metadataFile.readAsString();
final jsonMetadata = jsonDecode(metadataString);
final jsonMetadata = jsonDecode(metadataString) as Map<String, Object?>;

final T data = deserialiser(dynamicData);
final timestamp = DateTime.parse(jsonMetadata['timestamp']);
final timestamp = DateTime.parse(jsonMetadata['timestamp'] as String);
final hasData = HasData<T>(data, timestamp, scope);

cache[relativePath] = hasData;
Expand Down