Rust can parse Very Long nine tails since 1.55.0#17
Open
nabijaczleweli wants to merge 1 commit intolikebike:masterfrom
Open
Rust can parse Very Long nine tails since 1.55.0#17nabijaczleweli wants to merge 1 commit intolikebike:masterfrom
nabijaczleweli wants to merge 1 commit intolikebike:masterfrom
Conversation
|
I think should be conditionalized on rust version. With rust 1.54.0 this test now fails. |
Beholden most likely to rust-lang/rust@8752b40 Closes likebike#16
nabijaczleweli
force-pushed
the
1.55.0
branch
from
a355a80 to
e909b66
Compare
Author
|
Yeah, fair. |
|
I tested this with rust-1.54.0-1.fc33.x86_64 and cargo-1.56.1-1.fc33.x86_64 and the tests pass in both cases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
False negative in the test, nbd