Conversation
Member
|
merged linagora/enough_html_editor#37. please update |
tddang-linagora
previously approved these changes
May 23, 2025
…nline image in body Signed-off-by: dab246 <tdvu@linagora.com>
dab246
force-pushed
the
bugfix/tf-3740-duplicated-signatures-when-changing-the-from-field-on-mobile
branch
from
607ae49 to
3314379
Compare
Member
Author
Updated |
hoangdat
approved these changes
May 23, 2025
tddang-linagora
approved these changes
May 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
#3740
Root cause
Because inserting the image and then entering the text accidentally placed the
signaturetag inside thedivtag. Therefore, when removing and inserting the signature, the DOM Selector statementdocument.querySelector('#editor > .tmail-signature');did not find any direct child elements of#editorwith the class.tmail-signature.Solution
Use the Selector
document.querySelector('#editor .tmail-signature');to find any children within#editorwith the classtmail-signature, regardless of nesting level.Dependency
Resolved
demo-android.online-video-cutter.com.mp4