ci: pin publish workflow to minimum supported Node version#113
Merged
Conversation
The publish workflow should use Node 22 (the minimum supported version per engines.node >=22.0.0) to ensure maximum compatibility for all users. The CI matrix already validates both Node 22 and 24. Also adds a Renovate package rule to prevent automated bumps of the Node version in the publish workflow. Refs #106
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pin the publish workflow to Node 22 (the minimum supported version) and prevent Renovate from bumping it.
Motivation
PR #106 proposes upgrading the publish workflow from Node 22 → 24. However, the publish workflow should use the minimum supported version (
engines.node >= 22.0.0) to ensure maximum compatibility for all users. The CI matrix already validates both Node 22 and 24, so there is no need to also publish on 24.Publishing with a newer Node/npm version can introduce subtle differences in package artifacts that may not be compatible with the minimum supported runtime.
Changes
.github/workflows/publish.yml: Added a comment clarifying the intentional pin to Node 22renovate.json: Added a package rule to disable Renovate updates of the Node version in the publish workflowRelated
Refs #106 — once this is merged, #106 can be closed.