Skip to content

fix(#60): fix: replace empty catch blocks with meaningful error handling #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
xodn348 wants to merge 1 commit into from
Closed

fix(#60): fix: replace empty catch blocks with meaningful error handling #88

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
90 changes: 8 additions & 82 deletions src/common/token-storage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,86 +1,12 @@
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
import { decryptToken, encryptToken } from "./encryption.js";

const DIR_NAME = "linearis";
const LEGACY_DIR_NAME = ".linearis";
const TOKEN_FILE = "token";

export function getTokenDir(): string {
if (process.platform === "linux") {
const xdgConfig = process.env.XDG_CONFIG_HOME;
if (xdgConfig && path.isAbsolute(xdgConfig)) {
return path.join(xdgConfig, DIR_NAME);
}
return path.join(os.homedir(), ".config", DIR_NAME);
}
return path.join(os.homedir(), LEGACY_DIR_NAME);
}

function getLegacyTokenDir(): string {
return path.join(os.homedir(), LEGACY_DIR_NAME);
}

function getTokenPath(): string {
return path.join(getTokenDir(), TOKEN_FILE);
}

function getLegacyTokenPath(): string {
return path.join(getLegacyTokenDir(), TOKEN_FILE);
}

export function ensureTokenDir(): void {
const dir = getTokenDir();
if (!fs.existsSync(dir)) {
fs.mkdirSync(dir, { recursive: true, mode: 0o700 });
} else {
fs.chmodSync(dir, 0o700);
}
}

export function saveToken(token: string): void {
ensureTokenDir();
const tokenPath = getTokenPath();
const encrypted = encryptToken(token);
fs.writeFileSync(tokenPath, encrypted, "utf8");
fs.chmodSync(tokenPath, 0o600);
}

export function getStoredToken(): string | null {
const tokenPath = getTokenPath();
if (!fs.existsSync(tokenPath)) {
// on linux, fall back to legacy ~/.linearis/token
if (process.platform === "linux") {
const legacy = getLegacyTokenPath();
if (fs.existsSync(legacy)) {
try {
const encrypted = fs.readFileSync(legacy, "utf8").trim();
return decryptToken(encrypted);
} catch {
return null;
}
}
}
return null;
}
try {
const encrypted = fs.readFileSync(tokenPath, "utf8").trim();
return decryptToken(encrypted);
} catch {
return null;
}
}

export function clearToken(): void {
const tokenPath = getTokenPath();
if (fs.existsSync(tokenPath)) {
fs.unlinkSync(tokenPath);
}
if (process.platform === "linux") {
const legacy = getLegacyTokenPath();
if (fs.existsSync(legacy)) {
fs.unlinkSync(legacy);
} catch (error) {
// ENOENT = race between existsSync and readFileSync — treat as missing
if ((error as NodeJS.ErrnoException).code !== "ENOENT") {
process.stderr.write(
`Warning: failed to decrypt stored token: ${error instanceof Error ? error.message : String(error)}\n`,
);
}
}
}
return null;
}