Add lerp_rect_unpremultiplied
#199
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Should we add this method to other color types too? |
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
tomcur
reviewed
Oct 28, 2025
Member
tomcur
left a comment
tomcur
left a comment
There was a problem hiding this comment.
I see the usefulness of this method: there are similar arguments for this as for the unpremultiplied interpolation/gradient support we've added (#191).
However, this work and the prior work on interpolation/gradients introduces noise to the API with what is arguably the wrong behavior for most use-cases, and that noise has to be justified. Correctly implementing interpolation/gradients is very much non-trivial, which to me justifies that noise. I'm much less sure about the method proposed here, as the implementation is straightforward enough for users of Color that need this to implement themselves.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently roll own version in vello classic, but it would be nice to upstream this: linebender/vello#1268 (comment). IMO it would make more sense to have
lerp_rect_premultiplied, but we do not want breaking changes.