Move line break opportunity overrides into parley_core - #648
Merged
Conversation
tomcur
commented
Jun 23, 2026
| /// # use parley::{CHROMIUM_LINE_BREAK_OVERRIDE, FontContext, LayoutContext}; | ||
| /// # let mut font_cx = FontContext::default(); | ||
| /// # let mut layout_cx: LayoutContext<[u8; 4]> = LayoutContext::new(); | ||
| /// ```ignore |
Member
Author
There was a problem hiding this comment.
Similarly to the non_exhaustive, this doctest is re-enabled in the next PR.
tomcur
force-pushed
the
parley-core-lboverride
branch
from
June 26, 2026 14:21
18e3eb4 to
0b59996
Compare
Temporarily removes `#[non_exhaustive]` from `LineBreakContext` to allow `parley` to construct it.
tomcur
force-pushed
the
parley-core-lboverride
branch
from
June 26, 2026 14:41
0b59996 to
4976ea3
Compare
taj-p
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On top of #647.
Temporarily removes
#[non_exhaustive]fromLineBreakContextto allowparleyto construct it (becomesnon_exhaustiveagain once the next PR lands).