Fix handling of line break overrides before newlines - #676
Merged
Conversation
DJMcNab
enabled auto-merge
July 6, 2026 23:58
nicoburns
approved these changes
Jul 7, 2026
nicoburns
left a comment
nicoburns
left a comment
Collaborator
There was a problem hiding this comment.
Makes sense. And I'm also inclined to trust your internal testing of this until such time as we have a better setup here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing code had a bug where this would have made a soft break happen immediately before a mandatory break, which means that the mandatory break would have been pushed down a line, which is wrong.
Note that the a "visual" reproduction relies on Canva's forked, unconditional implementation of #619 (see conor-93#3), so I haven't added a test here.