Skip to content

Update to kurbo@0.11.3 #1110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DJMcNab merged 1 commit into from
Jul 22, 2025
Merged

Update to kurbo@0.11.3 #1110

DJMcNab merged 1 commit into from
Jul 22, 2025

Conversation

@sagudev
Copy link
Contributor

@sagudev sagudev commented Jul 18, 2025 •
edited
Loading

Depends on linebender/kurbo#467

Fixes #1066.

@sagudev
Update kurbo to 0.11.3
1fc10f3 
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
@sagudev sagudev marked this pull request as ready for review July 22, 2025 06:07
DJMcNab
DJMcNab approved these changes Jul 22, 2025
View reviewed changes
Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can land this? Does it have any value for us?

@sagudev
Copy link
Contributor Author

sagudev commented Jul 22, 2025

Does it have any value for us?

Yes, it will fix #1066.

@sagudev sagudev added this pull request to the merge queue Jul 22, 2025
@DJMcNab DJMcNab removed this pull request from the merge queue due to a manual request Jul 22, 2025
@DJMcNab
Copy link
Member

DJMcNab commented Jul 22, 2025

I'd like some clarification on that then - this PR has not been marked as fixing that issue; is that because you want to leave it open to track adding a regression test (i.e. #1067)?

I don't want to leave that as an orphan issue, and it's a nicer UX if the close event is correctly linked to the PR which addresses the issue.

@sagudev
Copy link
Contributor Author

sagudev commented Jul 22, 2025

I'd like some clarification on that then - this PR has not been marked as fixing that issue; is that because you want to leave it open to track adding a regression test (i.e. #1067)?

I don't want to leave that as an orphan issue, and it's a nicer UX if the close event is correctly linked to the PR which addresses the issue.

Yeah, I was planning to close in it with regression test, but I agree it's better to close it here.

Do land if you think it's okay now.

@DJMcNab DJMcNab added this pull request to the merge queue Jul 22, 2025
Merged via the queue into linebender:main with commit daf9402 Jul 22, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomcur tomcur tomcur approved these changes

@DJMcNab DJMcNab DJMcNab approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Negative dash offsets are rendered wrong

3 participants

@sagudev @DJMcNab @tomcur