perf(vello_common): track has_opacities to skip alpha blending #1329
+128
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grebmeg
force-pushed
the
gemberg/tests-diff-log-data
branch
from
52be151 to
d9ec9a2
Compare
grebmeg
changed the base branch from
main
to
gemberg/perf/image-rendering-improvements
grebmeg
force-pushed
the
gemberg/perf/image-rendering-improvements
branch
from
2d4526c to
422ece4
Compare
grebmeg
force-pushed
the
gemberg/gemberg/perf/image-rendering-improvements2
branch
from
72652c0 to
10b89a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By tracking image opacities, we can skip alpha blending for fully opaque image fills and directly override
blend_buf(code here), resulting in a notable performance gain over the main branch (this figure includes the earlier #1327, which gives roughly a 33.3% boost; the change here adds about ~11.8% on top of that.):