fix(no-single-variables-to-translate): allow top-level calls to plural/select/selectOrdinal#133
Open
jtbandes wants to merge 2 commits intolingui:mainfrom
Open
fix(no-single-variables-to-translate): allow top-level calls to plural/select/selectOrdinal#133jtbandes wants to merge 2 commits intolingui:mainfrom
jtbandes wants to merge 2 commits intolingui:mainfrom
Conversation
Author
|
Hi @timofei-iatsenko, any interest in this patch? |
jtbandes
force-pushed
the
fix-toplevel-plural
branch
from
c548c5f to
b72abf3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #126
This PR updates the
no-single-variables-to-translatelogic to explicitly allow syntax likemsg`${plural(...)}`, which seems to be the recommended way to do plural messages with a custom i18n instance (outside of JSX), according to this discussion: lingui/js-lingui#1312 (comment)