Skip to content

Build with Go 1.11 #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bai merged 1 commit into from
Dec 10, 2018
Merged

Build with Go 1.11 #450

bai merged 1 commit into from
Dec 10, 2018

Conversation

@bai
Copy link
Collaborator

@bai bai commented Sep 17, 2018 •
edited
Loading

Since #405 Go 1.11 has been released so this PR switches Go build image to version 1.11 (Alpine 3.8).

Best served with #447.

@coveralls
Copy link

coveralls commented Sep 17, 2018

Coverage Status

Coverage remained the same at 73.985% when pulling 653fc1a on bai:go111 into 12e681a on linkedin:master.

@coveralls
Copy link

coveralls commented Sep 17, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 73.993% when pulling cb004f9 on bai:go111 into 6f0e490 on linkedin:master.

vvuibert
vvuibert reviewed Sep 19, 2018
View reviewed changes
Copy link
Contributor

@vvuibert vvuibert left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you also have to update the TRAVIS_GO_VERSION in .travis.yml

sam-obeid
sam-obeid approved these changes Oct 10, 2018
View reviewed changes
Copy link

@sam-obeid sam-obeid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vvuibert vvuibert mentioned this pull request Oct 26, 2018
Merged
@bai bai merged commit 3f33e36 into linkedin:master Dec 10, 2018
@bai bai deleted the go111 branch December 10, 2018 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@andrewjamesbrown andrewjamesbrown andrewjamesbrown approved these changes

@vvuibert vvuibert vvuibert approved these changes

@sam-obeid sam-obeid sam-obeid approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bai @coveralls @andrewjamesbrown @vvuibert @sam-obeid