Skip to content

Updating min count validation to 1 in fetchSize and rowCountLimit#1010

Merged
harshOSS merged 1 commit into
masterfrom
updating-logic
May 7, 2026
Merged

Updating min count validation to 1 in fetchSize and rowCountLimit#1010
harshOSS merged 1 commit into
masterfrom
updating-logic

Conversation

@harshOSS
Copy link
Copy Markdown
Collaborator

@harshOSS harshOSS commented May 7, 2026 •
edited
Loading

Summary

  • Updating min count validation to 1 in fetchSize and rowCountLimit . as minValue as 0 does not make any sense and we should not allow that

Testing Done

  • mint build

mittalprince
mittalprince approved these changes May 7, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@mittalprince mittalprince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshOSS harshOSS merged commit 75a1a22 into master May 7, 2026
1 check passed
@harshOSS harshOSS mentioned this pull request May 7, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mittalprince mittalprince mittalprince approved these changes

@kanishkjaiswal2015 kanishkjaiswal2015 kanishkjaiswal2015 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@harshOSS @mittalprince @kanishkjaiswal2015