Remove various "Raw" APIs in the cache#32
Merged
PapaCharlie merged 1 commit intomasterfrom Sep 17, 2025
Merged
Conversation
PapaCharlie
force-pushed
the
pc/raw
branch
5 times, most recently
from
37f97e2 to
60d8fcb
Compare
These raw APIs were always very awkward and poluted the overall `diderot` namespace with useless functions. Wrapping the API makes this cleaner and puts all the methods in a single place. It also removes unnecessary/redundant methods that used to be required when implementing custom caches.
bohhyang
approved these changes
Sep 16, 2025
singhsanjay12
added a commit
to singhsanjay12/diderot
that referenced
this pull request
Jan 16, 2026
This reverts commit 0f097ed.
whutwhu
pushed a commit
that referenced
this pull request
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These raw APIs were always very awkward and poluted the overall
diderotnamespace with useless functions. Wrapping the API makes this cleaner and puts all the methods in a single place. It also removes unnecessary/redundant methods that used to be required when implementing custom caches.