xds: fix VHDS empty subscription behavior to prevent wildcarding subscription#34
Merged
whutwhu merged 3 commits intolinkedin:masterfrom Jan 8, 2026
Merged
xds: fix VHDS empty subscription behavior to prevent wildcarding subscription#34whutwhu merged 3 commits intolinkedin:masterfrom
whutwhu merged 3 commits intolinkedin:masterfrom
Conversation
|
Can you also add a test plan? |
gu0keno0
reviewed
Jan 8, 2026
There was a problem hiding this comment.
Contributor
Author
I’ve added some unit tests and also did manual validation via the Observer to ensure the subscription is ignored when the resource is VHDS with either a wildcard or an empty subscription. |
abhics1002
approved these changes
Jan 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where the control plane incorrectly treated an empty resource_names_subscribe list in a VHDS DeltaDiscoveryRequest as a wildcard subscription.
According to the Virtual Host Discovery Service (VHDS) documentation, VHDS is designed for on-demand loading. Interpreting an empty subscription list as a wildcard is counter-productive to the "lazy-loading" goal of VHDS, as it could cause the control plane to push all virtual hosts to the proxy unexpectedly.
Changes
Risk Level
Low. This specifically targets VHDS resource types and aligns with the expected xDS protocol behavior for on-demand resources.
Testing Done
I performed manual validation via the Observer to ensure the subscription is ignored when the resource is VHDS with either a wildcard or an empty subscription.