fix(destination)!: Disallow requests to undefined service ports - #15473
Merged
Conversation
Signed-off-by: Alex Leong <alex@buoyant.io>
Signed-off-by: Alex Leong <alex@buoyant.io>
raykroeker
requested changes
Jul 15, 2026
| case <-s.shutdown: | ||
| case <-canceled: | ||
| log.Debugf("GetProfile %s cancelled", fqn) | ||
| case <-streamEnd: |
Contributor
There was a problem hiding this comment.
It appears as if this case is unreachable, does it make sense to create streamEnd below?
Signed-off-by: Alex Leong <alex@buoyant.io>
raykroeker
approved these changes
Jul 15, 2026
alpeb
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#14149 fixed #13922 in the case where no ServiceProfile was defined for the target service.
However, when a ServiceProfile is defined for a service, Linkerd will use the
GetProfileAPI instead of the client policy API and requests will be allowed to ports not defined in the service.Unfortunately, the
GetProfileAPI does not have a mechanism to signal that connections should be denied. Therefore, when we encounter aGetProfilerequest for a port which is not defined on the service, we return an emptyDestinationProfile. This causes the proxy to fall back to the client policy API which correctly returns a Forbidden filter and causes the connection to be denied.We also add an integration test for both the ServiceProfile and non-ServiceProfile cases.