fix(viz/tap): avoid empty path segment when tapping a resource kind - #15487
Open
amarkdotdev wants to merge 1 commit into
Open
fix(viz/tap): avoid empty path segment when tapping a resource kind#15487amarkdotdev wants to merge 1 commit into
amarkdotdev wants to merge 1 commit into
Conversation
When tapping a whole category (e.g. `linkerd tap po`), the request name is empty. The old URL had a blank segment (`.../pods//tap`), which some API servers (notably k3d/k3s) reject with unexpected EOF. Use `.../pods/tap` for collection taps and register a matching route. Fixes linkerd#5219 Signed-off-by: amarkdotdev <amarkdotdev@users.noreply.github.com>
amarkdotdev
force-pushed
the
fix/tap-empty-resource-name-path-5219
branch
from
July 21, 2026 19:26
1086406 to
0fbafaa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5219
Tapping a whole resource category (
linkerd tap po) builds a URL with a blank name segment (.../pods//tap). Some API servers, including k3d/k3s, reject that with unexpected EOF. Named resources still worked.Collection taps now use
.../pods/tap, and the tap API registers a matching route.Testing
go test ./viz/tap/pkg/ ./viz/tap/api/ -count=1