Support separate inbound and outbound subnet skips - #15496
Draft
hooiv wants to merge 1 commit into
Draft
Conversation
Problem: proxy-init cannot independently exclude inbound source subnets and outbound destination subnets from redirection. Solution: expose separate subnet settings through pod annotations and chart values while preserving the existing skip-subnets setting. Validation: go test ./pkg/inject -run '^TestGetOverriddenValues$' -count=1; go test ./pkg/charts/linkerd2 ./pkg/k8s Signed-off-by: hooiv <125276621+hooiv@users.noreply.github>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The existing
config.linkerd.io/skip-subnetssetting cannot distinguish inbound source-subnet exclusions from outbound destination-subnet exclusions. This makes it impossible to configure the desired behavior for both traffic directions.Solution
Add
config.linkerd.io/skip-inbound-subnetsandconfig.linkerd.io/skip-outbound-subnetspod annotations, chart values, and proxy-init argument wiring. The existingskip-subnetsannotation and value remain backwards compatible.This is the Linkerd control-plane companion to linkerd/linkerd2-proxy-init#792 and addresses #10726.
Validation
go test ./pkg/inject -run '^TestGetOverriddenValues$' -count=1go test ./pkg/charts/linkerd2 ./pkg/k8sgit diff --checkSigned-off-by: ADITYA CHAUHAN hooiv@users.noreply.github.com