Fix ACLP Alerts Implementation #878
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yec-akamai
added
the
improvement
yec-akamai
requested review from
psnoch-akamai and
vshanthe
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issues with ACLP (Alert and Monitoring) alerts functionality by reverting alert channels listing due to API breaking changes, fixing struct definitions, and adding a helper function to wait for alert definition status.
Changes:
- Reverted alert channels listing functionality to be re-implemented later
- Fixed type definitions in alert definition structs (Status, EntityIDs)
- Added
WaitForAlertDefinitionStatusReady()function for polling alert definition status
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| waitfor.go | Added new function to wait for alert definition to reach ready status |
| test/integration/monitor_alert_definitions_test.go | Commented out alert channel queries and used hardcoded channel ID |
| test/integration/fixtures/TestMonitorAlertDefinition_CreateWithIdempotency.yaml | Updated test fixture with new timestamps and user IDs |
| test/integration/fixtures/TestMonitorAlertDefinition.yaml | Updated test fixture data with new entity IDs and additional test alerts |
| test/integration/fixtures/TestMonitorAlertChannels_List.yaml | Removed entire fixture file content |
| monitor_alert_definitions.go | Added AlertDefinitionStatus type, fixed EntityIDs type, added AlertChannelEnvelope struct |
| monitor_alert_channels.go | New file with commented-out alert channel code for future implementation |
| alert_channels.go | Deleted file containing alert channel implementation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR did a few things to fix ACLP alerts related functions:
WaitForAlertDefinitionStatusReady()functionThis PR is the dependency of the terraform PR: linode/terraform-provider-linode#2234
✔️ How to Test