Fix configuration header for canctrl.h file #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@marckleinebudde I noticed this error testing the upstream with the gs_usb again today. This fix enables the system to work with libsocketcan again. |
Contributor
|
@jjorge-geotab what about also removing |
jjorge-geotab
force-pushed
the
fix_config_canctrl
branch
from
f1d40c1 to
9ca66b1
Compare
Contributor
Author
|
@yegorich I just removed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
During some tests, I noticed a regression in the canctrl.h file which is not including the config.h file added in the PR #35
I don't know if this is a regression added later or if it is wrong since the beggining ( I recall to test it) but, anyway, it is necessary to make the configuration to work using libsocketcan.