blktests: fix diy output in oscheck run task#42
Merged
dagomez137 merged 1 commit intomainfrom Sep 29, 2025
Merged
Conversation
The diy callback plugin was throwing warnings about undefined 'cmd'
attribute because the template attempted to access command information
through ansible_callback_diy.result.output.cmd, which doesn't exist
for ansible.builtin.command modules.
Fixed by using ansible_callback_diy.task.args._raw_params to access
the actual command being executed, and replaced ansible_host with
inventory_hostname for proper variable scope in the callback context.
Debugging with the following vars helped finding the root cause:
ansible_callback_diy_runner_on_ok_msg: |
DEBUG - Result keys: {{ ansible_callback_diy.result.output.keys() | list }}
DEBUG - Task args: {{ ansible_callback_diy.task.args }}
DEBUG - Direct keys: {{ ansible_callback_diy.keys() | list }}
$ {{ ansible_callback_diy.task.args._raw_params | default('command') }}
{{ stdout | default('') }}
Output:
TASK: Run blktests using oscheck.sh [dgc-testing-block,dgc-testing-nvme]
DEBUG - Result keys: ['changed', '_ansible_no_log', 'censored']
DEBUG - Task args: {'chdir': '/usr/local/blktests/', '_raw_params':
'./oscheck.sh --print-start --print-done --test-group block block/003'}
DEBUG - Direct keys: ['playbook', 'play', 'task', 'result', 'top_level_var_names']
$ ./oscheck.sh --print-start --print-done --test-group block block/003
DEBUG - Result keys: ['changed', '_ansible_no_log', 'censored']
DEBUG - Task args: {'chdir': '/usr/local/blktests/', '_raw_params':
'./oscheck.sh --print-start --print-done --test-group nvme block/003'}
DEBUG - Direct keys: ['playbook', 'play', 'task', 'result', 'top_level_var_names']
$ ./oscheck.sh --print-start --print-done --test-group nvme block/003
Generated-by: Claude AI
Signed-off-by: Daniel Gomez <da.gomez@samsung.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The diy callback plugin was throwing warnings about undefined 'cmd' attribute because the template attempted to access command information through ansible_callback_diy.result.output.cmd, which doesn't exist for ansible.builtin.command modules.
Fixed by using ansible_callback_diy.task.args._raw_params to access the actual command being executed, and replaced ansible_host with inventory_hostname for proper variable scope in the callback context.
Debugging with the following vars helped finding the root cause:
ansible_callback_diy_runner_on_ok_msg: |
DEBUG - Result keys: {{ ansible_callback_diy.result.output.keys() | list }}
DEBUG - Task args: {{ ansible_callback_diy.task.args }}
DEBUG - Direct keys: {{ ansible_callback_diy.keys() | list }}
$ {{ ansible_callback_diy.task.args._raw_params | default('command') }}
{{ stdout | default('') }}
Output:
TASK: Run blktests using oscheck.sh [dgc-testing-block,dgc-testing-nvme] DEBUG - Result keys: ['changed', '_ansible_no_log', 'censored'] DEBUG - Task args: {'chdir': '/usr/local/blktests/', '_raw_params':
'./oscheck.sh --print-start --print-done --test-group block block/003'}
DEBUG - Direct keys: ['playbook', 'play', 'task', 'result', 'top_level_var_names'] $ ./oscheck.sh --print-start --print-done --test-group block block/003 DEBUG - Result keys: ['changed', '_ansible_no_log', 'censored'] DEBUG - Task args: {'chdir': '/usr/local/blktests/', '_raw_params': './oscheck.sh --print-start --print-done --test-group nvme block/003'} DEBUG - Direct keys: ['playbook', 'play', 'task', 'result', 'top_level_var_names'] $ ./oscheck.sh --print-start --print-done --test-group nvme block/003
Generated-by: Claude AI