Makefile: terraform wasn't building the kdevops_nodes file#43
Merged
chucklever merged 1 commit intomainfrom Oct 3, 2025
Merged
Makefile: terraform wasn't building the kdevops_nodes file#43chucklever merged 1 commit intomainfrom
chucklever merged 1 commit intomainfrom
Conversation
When "make bringup" runs "terraform plan", it complains that the kdevops_nodes variable isn't set. extra_vars.yaml does contain the variable, but I'm guessing that somehow gen_nodes runs after gen_tfvars now? Not really sure. Daniel suggests: > I think it'd be best to move KDEVOPS_NODES just after we assign > the filename to it (provision.Makefile -> guestfs.Makefile): Fixes: 5457b74 ("Makefile: fix target dependency order") Signed-off-by: Daniel Gomez <da.gomez@kernel.org>
chucklever
force-pushed
the
makefile-fixes
branch
from
41e280e to
77d0fa2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When "make bringup" runs "terraform plan", it complains that the kdevops_nodes variable isn't set.
extra_vars.yaml does contain the variable, but I'm guessing that somehow gen_nodes runs after gen_tfvars now? Not really sure.
Daniel suggests:
Fixes: 5457b74 ("Makefile: fix target dependency order")