Conversation
When locales-all support was added in commit 2514a69 ("guestfs: fix locale warnings in VM deployment"), it was added for all distros in the virt-builder.j2 template as well as Ansible tasks to ensure idempotency on previous base images. But we just need to ensure en_US.UTF-8 is available on the guests image, so keep just this config in both template and tasks but remove locales-all. While we are at it, also move the locale configuration after all deps are installed and to the distro agnostic task section. We do it anyways for all distros in virt-builder.j2, this ensures idempotency in all of them. Fixes: 6bb3bfb ("base_image: Skip "locales-all" package installation") Link: https://github.com/linux-kdevops/kdevops/actions/runs/18347971703/job/52259752236 [1] Link: https://lore.kernel.org/r/20250929-locales-all-removal-v1-1-4177411d3e44@samsung.com Signed-off-by: Daniel Gomez <da.gomez@samsung.com>
Permissions should be set regardless of if we executed the copy task
or not.
Workflow:
TASK: Show the custom virt-builder database [localhost]
Custom virt-builder source:
/etc/virt-builder/repos.d/
kdevops-custom-images-debian-13-generic-arm64-daily.conf
Custom virt-builder index:
/var/lib/libvirt/images/kdevops/guestfs/custom_images/
debian-13-generic-arm64-daily/index
Custom virt-builder image:
/var/lib/libvirt/images/kdevops/guestfs/custom_images/
debian-13-generic-arm64-daily/debian-13-generic-arm64-daily.raw
TASK: Generating the index for debian-13-generic-arm64-daily [localhost]
⠀⠀✓ [localhost]
TASK: Copy custom image to base image location (with automatic reflink
optimization) [localhost]
⠀⠀⊘ [localhost]
TASK: Set proper permissions on base image [localhost]
⠀⠀⊘ [localhost]
TASK: Create the base OS image [localhost]
⠀⠀⊘ [localhost]
...
Fixes error:
TASK: Duplicate the root disk image for each target node
[dgc-testing-block,dgc-testing-nvme]
⠀⠀FAILED: [dgc-testing-block] => non-zero
return code STDERR: cp: cannot open
'/var/lib/libvirt/images/kdevops/guestfs/custom_images/
debian-13-generic-arm64-daily/debian-13-generic-arm64-daily.raw' for
reading: Permission denied
[ERROR]: Task failed: Module failed: non-zero return code
Origin:
/home/dagomez.linux/src/kdevops/playbooks/roles/guestfs/tasks/bringup/
main.yml:53:7
51 delegate_to: localhost
52
53 - name: Duplicate the root disk image for each target node
^ column 7
Fixes: f9ef79c ("base_image: optimize VM image copying with reflinks and fix same-file handling")
Link: https://lore.kernel.org/r/20250929-locales-all-removal-v1-2-4177411d3e44@samsung.com
Signed-off-by: Daniel Gomez <da.gomez@samsung.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.