Conversation
Add Fedora 43, remove Fedora 41 from Testing Farm CI Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates Testing Farm CI workflow to drop Fedora 41 support and add Fedora 43 with appropriate Ansible versions, while keeping Fedora 42 in the test matrix and supported platforms detection. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `.github/workflows/tft.yml:103-104` </location>
<code_context>
- ansible_version: 2.17
- platform: Fedora-42
ansible_version: 2.19
+ - platform: Fedora-43
+ ansible_version: 2.20
- platform: CentOS-7-latest
ansible_version: 2.9
</code_context>
<issue_to_address>
**issue (bug_risk):** Quote the `ansible_version: 2.20` value to avoid YAML treating it as a numeric and normalizing it to `2.2`.
Because YAML treats `2.20` as a number, it may be read back as `2.2`, which can lead to installing the wrong Ansible version if this value is used in package specs (e.g., `ansible==${{ matrix.ansible_version }}`). Quoting it as a string (`"2.20"`) avoids this and preserves the intended version.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
+103
to
+104
| - platform: Fedora-43 | ||
| ansible_version: 2.20 |
There was a problem hiding this comment.
issue (bug_risk): Quote the ansible_version: 2.20 value to avoid YAML treating it as a numeric and normalizing it to 2.2.
Because YAML treats 2.20 as a number, it may be read back as 2.2, which can lead to installing the wrong Ansible version if this value is used in package specs (e.g., ansible==${{ matrix.ansible_version }}). Quoting it as a string ("2.20") avoids this and preserves the intended version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Fedora 43, remove Fedora 41 from Testing Farm CI
Signed-off-by: Rich Megginson rmeggins@redhat.com
Summary by Sourcery
Update Testing Farm GitHub workflow to test against the current Fedora releases.
CI: