ci: tox-lsr 3.16.0 - fix qemu tox test failures - rename to qemu-ansible-core-X-Y [citest_skip]

[richm]

the latest version of tox 4.49 has a strange issue - it thinks that a tox testenv
like [qemu-ansible-core-2.20] is specifying python 2.20 which conflicts with the
testenv basepython of python 3.latest. There appears to be no way to workaround this.

So, rename all of the testenvs to use major-minor instead of major.minor e.g.
[qemu-ansible-core-2-20]

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Update CI tox-lsr usage and qemu/container test environment naming to be compatible with newer tox versions.

Build:

• Bump tox-lsr version from 3.15.0 to 3.16.0 across GitHub Actions workflows.

CI:

• Rename qemu and container ansible-core tox environments from dotted to dashed version identifiers in the qemu-kvm integration workflow to avoid tox Python version parsing issues.

Documentation:

• Update contributing documentation to reference the new qemu tox environment name with dashed ansible-core version.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates CI tox integration to tox-lsr 3.16.0 and renames qemu/container tox environments from dot-separated ansible-core versions to dash-separated ones to avoid tox 4.49 interpreting them as Python version specifiers, with docs adjusted accordingly.

File-Level Changes

Change	Details	Files
Rename qemu/container tox environments from dot to dash version format to avoid tox 4.49 interpreting them as Python versions.	Update qemu-ansible-core-X.Y environment names in the qemu-kvm integration workflow matrix to qemu-ansible-core-X-Y. Update container-ansible-core-X.Y environment names in the qemu-kvm integration workflow matrix to container-ansible-core-X-Y. Keep commented-out and duplicated matrix entries consistent with the new dash-based naming convention.	.github/workflows/qemu-kvm-integration-tests.yml
Bump tox-lsr used in CI workflows from 3.15.0 to 3.16.0 to pick up fixes (including qemu env renames).	Change pip installation of tox-lsr from version 3.15.0 to 3.16.0 in the qemu-kvm integration tests workflow. Change pip installation of tox-lsr from version 3.15.0 to 3.16.0 in the ansible-lint workflow. Change pip installation of tox-lsr from version 3.15.0 to 3.16.0 in the ansible-managed-var-comment workflow. Change pip installation of tox-lsr from version 3.15.0 to 3.16.0 in the ansible-test workflow.	.github/workflows/qemu-kvm-integration-tests.yml .github/workflows/ansible-lint.yml .github/workflows/ansible-managed-var-comment.yml .github/workflows/ansible-test.yml
Align contributor documentation with new qemu tox environment naming convention.	Update example tox command to use qemu-ansible-core-2-20 instead of qemu-ansible-core-2.14, reflecting both the dash-based naming and a newer ansible-core version.	contributing.md

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• The example in contributing.md now uses qemu-ansible-core-2-20, whereas the previous example was 2.14 and the workflows only reference up to 2-19; please confirm the intended ansible-core version and keep the example consistent with supported environments.
• Since the tox env names have changed from X.Y to X-Y, it’s worth scanning for any remaining references to the old names outside these workflows (e.g., other workflows, scripts, or CI config) to avoid mismatch errors when invoking tox.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The example in `contributing.md` now uses `qemu-ansible-core-2-20`, whereas the previous example was `2.14` and the workflows only reference up to `2-19`; please confirm the intended ansible-core version and keep the example consistent with supported environments.
- Since the tox env names have changed from `X.Y` to `X-Y`, it’s worth scanning for any remaining references to the old names outside these workflows (e.g., other workflows, scripts, or CI config) to avoid mismatch errors when invoking tox.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}