ci: tox-lsr 3.17.0 - container test improvements, use ansible 2.20 for fedora 43 [citest_skip]

[richm]

tox-lsr 3.17.0 has some container test improvements - better output, faster runs

Use Ansible 2.20 for qemu/container tests on fedora 43

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Update CI workflows to use tox-lsr 3.17.0 and Ansible 2.20 for Fedora 43, and optimize container test runs.

CI:

• Bump tox-lsr version from 3.16.0 to 3.17.0 across GitHub Actions workflows.
• Switch Fedora 43 qemu and container test scenarios to use Ansible Core 2.20 instead of 2.19.
• Adjust container test job environment to avoid skipping requirements and callback plugins on the first test run, then enable skipping for subsequent runs to speed up execution.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Update GitHub Actions workflows to use tox-lsr 3.17.0 and Ansible 2.20 on Fedora 43, and adjust container test environment variables to leverage new tox-lsr container test behavior for faster, clearer runs.

Sequence diagram for CI container test run with tox-lsr 3_17_0 and Ansible 2_20

sequenceDiagram
  actor Developer
  participant GitHub as GitHub_Actions
  participant Workflow as ansible_test_workflow
  participant Tox as tox_lsr_3_17_0
  participant Engine as container_engine
  participant Cnt as test_container_fedora_43
  participant Ansible as ansible_2_20
  participant Role as role_under_test

  Developer->>GitHub: push_changes
  GitHub->>Workflow: trigger_workflow
  Workflow->>Workflow: install_tox_lsr_3_17_0
  Workflow->>Tox: run_tox_env_container_tests
  Tox->>Engine: start_container_with_env
  Engine->>Cnt: create_and_run_container
  Cnt-->>Tox: container_ready
  Tox->>Ansible: invoke_ansible_tests(version_2_20)
  Ansible->>Role: execute_role_tasks
  Role-->>Ansible: task_results
  Ansible-->>Tox: test_results
  Tox-->>Workflow: formatted_output_and_status
  Workflow-->>GitHub: publish_logs_and_status
  GitHub-->>Developer: report_ci_status

Loading

File-Level Changes

Change	Details	Files
Bump tox-lsr version used by CI workflows to 3.17.0.	Update pip installation of tox-lsr from 3.16.0 to 3.17.0 in qemu-kvm integration test workflow. Update pip installation of tox-lsr from 3.16.0 to 3.17.0 in ansible-lint workflow. Update pip installation of tox-lsr from 3.16.0 to 3.17.0 in ansible-managed-var-comment workflow. Update pip installation of tox-lsr from 3.16.0 to 3.17.0 in ansible-test workflow.	.github/workflows/qemu-kvm-integration-tests.yml .github/workflows/ansible-lint.yml .github/workflows/ansible-managed-var-comment.yml .github/workflows/ansible-test.yml
Switch Fedora 43 test matrix entries to use Ansible 2.20 for both qemu and container scenarios.	Change Fedora 43 qemu scenario env from qemu-ansible-core-2-19 to qemu-ansible-core-2-20. Change Fedora 43 container scenario env from container-ansible-core-2-19 to container-ansible-core-2-20. Change Fedora 43 bootc container scenario env from container-ansible-core-2-19 to container-ansible-core-2-20.	.github/workflows/qemu-kvm-integration-tests.yml
Adjust container test loop to control tox-lsr behavior via SKIP_* environment flags for performance while preserving full checks on the first test.	Remove previous LSR_CONTAINER_PROFILE and LSR_CONTAINER_PRETTY flags that disabled broken debug/profile setup. Ensure SKIP_REQUIREMENTS and SKIP_CALLBACK_PLUGINS are set to false before the first tox run so that the initial container test executes with full requirements and callback plugins. After each test run, set SKIP_REQUIREMENTS and SKIP_CALLBACK_PLUGINS to true so that subsequent tests can reuse setup and run faster.	.github/workflows/qemu-kvm-integration-tests.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}