ci: tox-lsr 3.17.1 - previous update broke container tests, this fixes them [citest_skip]

[richm]

tox-lsr 3.17.1 has a fix for the broken container tests

There was one shell function for both setting up the callback plugins and the connection plugin.
When this function was skipped, the ANSIBLE_CONNECTION_PLUGINS environment variable was not
set, so all subsequent tests failed. The connection plugin must be present and the env. var.
must be set in order to run any container tests. The code was fixed to ensure that there is
always a connection plugin installed in the correct location and that ANSIBLE_CONNECTION_PLUGINS
is always set and contains this path.

Also, setting up the callback plugins and the connection plugin is already idempotent, so no
reason to skip them.

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Update CI workflows to use tox-lsr 3.17.1 and adjust container test setup flags to ensure required plugins are always configured.

Bug Fixes:

• Ensure container integration tests always configure the required Ansible connection plugin by no longer skipping related setup via environment flags.

CI:

• Bump tox-lsr dependency from 3.17.0 to 3.17.1 across GitHub Actions workflows.
• Fix minor indentation in the container support check within the qemu-kvm integration tests workflow.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates GitHub Actions workflows to use tox-lsr 3.17.1 and ensures container tests always configure and use the required Ansible connection plugin by no longer skipping callback/connection plugin setup between tox runs.

Sequence diagram for container tests with tox-lsr 3_17_1 connection plugin setup

sequenceDiagram
    actor Developer
    participant GitHubActionsRunner as GitHubActionsRunner
    participant tox_lsr_3_17_1 as tox_lsr_3_17_1
    participant PluginSetup as PluginSetup
    participant Ansible as Ansible
    participant ContainerTest as ContainerTest

    Developer->>GitHubActionsRunner: push_changes
    GitHubActionsRunner->>GitHubActionsRunner: checkout_repository

    GitHubActionsRunner->>GitHubActionsRunner: pip_install tox_lsr_3_17_1

    GitHubActionsRunner->>tox_lsr_3_17_1: run_tox_env container_tests
    tox_lsr_3_17_1->>PluginSetup: setup_connection_plugin
    PluginSetup-->>tox_lsr_3_17_1: connection_plugin_installed

    tox_lsr_3_17_1->>PluginSetup: setup_callback_plugins
    PluginSetup-->>tox_lsr_3_17_1: callback_plugins_configured

    tox_lsr_3_17_1->>GitHubActionsRunner: export_env ANSIBLE_CONNECTION_PLUGINS=connection_plugin_path

    tox_lsr_3_17_1->>Ansible: invoke_ansible_tests
    Ansible->>ContainerTest: run_container_tests_with_connection_plugin
    ContainerTest-->>Ansible: test_results
    Ansible-->>tox_lsr_3_17_1: pass_fail
    tox_lsr_3_17_1-->>GitHubActionsRunner: exit_status
    GitHubActionsRunner-->>Developer: report_ci_status

Loading

File-Level Changes

Change	Details	Files
Upgrade tox-lsr dependency in all GitHub Actions workflows to 3.17.1 to pick up the fix for container tests.	Change pip install lines in multiple workflows to reference tox-lsr version 3.17.1 instead of 3.17.0	.github/workflows/qemu-kvm-integration-tests.yml .github/workflows/ansible-lint.yml .github/workflows/ansible-managed-var-comment.yml .github/workflows/ansible-test.yml
Ensure Ansible connection/callback plugin setup is always executed during qemu-kvm integration tests so ANSIBLE_CONNECTION_PLUGINS is consistently set.	Remove SKIP_CALLBACK_PLUGINS environment variable handling before and during the tests loop so callback/connection plugin setup is not skipped Keep SKIP_REQUIREMENTS toggling to avoid reinstalling requirements on subsequent test runs while still always configuring plugins	.github/workflows/qemu-kvm-integration-tests.yml
Fix shell indentation in the container tag detection logic to keep the yq-based galaxy tag check correctly scoped inside its conditional.	Indent the inner yq/galaxy_tags conditional within the image mismatch branch to reflect actual shell control flow and improve readability	.github/workflows/qemu-kvm-integration-tests.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• The tox-lsr version string is duplicated across several workflows; consider centralizing it via a reusable workflow, composite action, or a top-level env variable so future version bumps only require a single change.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The tox-lsr version string is duplicated across several workflows; consider centralizing it via a reusable workflow, composite action, or a top-level env variable so future version bumps only require a single change.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}